FIX Fix devtool error and remove comments in prod #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
GuySartorelli
changed the title
emteknetnz
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack complains and won't build in production mode because
devtoolis set to an empty string (which used to be acceptable). This has to befalsenow.docs: https://webpack.js.org/configuration/devtool/
I've also re-removed comments, which were being included by default against my expectations.
Having no comments is the behaviour for the CMS 4 version, so this just fixes a regression where that wasn't happening.
NOTE
After this is merged, I need to create a new
2.0.0-alpha2tag, re-release on npm, and runyarn installon all the related PRs so they're all using this new tag.Parent issue