Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileStatusIcon #45

Merged
merged 1 commit into from
May 24, 2020
Merged

Add FileStatusIcon #45

merged 1 commit into from
May 24, 2020

Conversation

emteknetnz
Copy link
Member

@brynwhyman brynwhyman mentioned this pull request May 7, 2020
Closed
37 tasks
robbieaverill
robbieaverill approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is implemented as a component rather than a font icon?

@emteknetnz
Copy link
Member Author

Any reason this is implemented as a component rather than a font icon?

The <FileStatusIcon> component has a nested <UncontrolledTooltip> component, as well as a bunch of logic built into it

https://github.com/silverstripe/silverstripe-admin/pull/1033/files#diff-a925d1817a55c5852f6801cc1c15324bR9

@Cheddam Cheddam merged commit 6e107e9 into silverstripe:master May 24, 2020
@Cheddam Cheddam deleted the pulls/master/file-status-icon branch May 24, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @robbieaverill @Cheddam