Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Update supported-modules list for CMS 5 #21

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

emteknetnz
Copy link
Member

Issue silverstripe/.github#22

Updated from this list https://docs.silverstripe.org/en/5/project_governance/supported_modules/

I copy pasted the list of of modules to a file list.txt and used this quick little script to update

<?php
$c=file_get_contents('list.txt');
$a=explode("\n",$c);
$a=array_filter($a);
$supported=[];
foreach($a as $l){
    preg_match("#([a-z].+?)\t#",$l,$m);
    $s=$m[1];
    $supported[]=$s;
}
$nj=[];
$j=json_decode(file_get_contents('modules.json'), true);
foreach($j as $a){
    if(!in_array($a['composer'], $supported)) continue;
    $nj[]=$a;
}
$c=json_encode($nj, 448);
$c=str_replace('  ',' ',$c);
file_put_contents('new-modules.json',$c);

@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 15, 2023

silverstripe/developer-docs isn't on the list in docs, but is a bit of a special case where I think we want it on the list in this repo anyway.

Discussion with max on slack about this:
Me:

https://docs.silverstripe.org/en/5/project_governance/supported_modules/ doesn't include developer-docs
This mostly makes sense - except that this list is the basis for updating our supported modules list in #21 which should include developer-docs.
Do you have any problem with us keeping developer-docs in the list in that repo even though it's not listed in the docs list?

Max:

To the extent that it's needed so it can feed into other system, I'm OK with it being in the silverstripe/supported-modules repo. I wouldn't want it to be on the official documented list of repo.
If/when we create a supported module service to keep track of those, we probably need side list for "things we care about that don't officially support".

Please add developer docs back to this list.

@emteknetnz
Copy link
Member Author

Updated

@GuySartorelli GuySartorelli merged commit 341fe2b into silverstripe:5 Mar 15, 2023
@GuySartorelli GuySartorelli deleted the pulls/5/update branch March 15, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants