Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Deprecate GraphQL #462

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/2/deprecate-graphql branch 2 times, most recently from 385a150 to 610dba1 Compare August 15, 2024 02:53
@@ -12,6 +12,8 @@

/**
* Scaffolds a generic update operation for DataObjects.
*
* @deprecated 5.3.0 Will be removed without equivalent functionality to replace it
*/
class UnpublishCreator extends AbstractPublishOperationCreator
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not calling deprecate in __construct() because that's already being done in AbstractPublishOperationCreator

Copy link
Member Author

@emteknetnz emteknetnz Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated to include call to deprecate

@emteknetnz emteknetnz force-pushed the pulls/2/deprecate-graphql branch from 610dba1 to 768a4a7 Compare August 15, 2024 05:03
@emteknetnz emteknetnz marked this pull request as ready for review August 16, 2024 04:57
@emteknetnz emteknetnz force-pushed the pulls/2/deprecate-graphql branch from 768a4a7 to f328b0a Compare August 18, 2024 21:37
@emteknetnz emteknetnz force-pushed the pulls/2/deprecate-graphql branch from f328b0a to 812d1a1 Compare August 18, 2024 21:42
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 2edf980 into silverstripe:2 Aug 19, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/deprecate-graphql branch August 19, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants