-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Deprecate GraphQL #462
API Deprecate GraphQL #462
Conversation
385a150
to
610dba1
Compare
@@ -12,6 +12,8 @@ | |||
|
|||
/** | |||
* Scaffolds a generic update operation for DataObjects. | |||
* | |||
* @deprecated 5.3.0 Will be removed without equivalent functionality to replace it | |||
*/ | |||
class UnpublishCreator extends AbstractPublishOperationCreator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not calling deprecate in __construct() because that's already being done in AbstractPublishOperationCreator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated to include call to deprecate
610dba1
to
768a4a7
Compare
768a4a7
to
f328b0a
Compare
f328b0a
to
812d1a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue silverstripe/silverstripe-admin#1799