Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove unused legacy graphql code #454

Merged

Conversation

emteknetnz
Copy link
Member

@@ -1,6 +1,6 @@
<?php

namespace SilverStripe\Versioned\Tests\GraphQL\Legacy\Plugins;
namespace SilverStripe\Versioned\Tests\GraphQL\Plugins;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace was wrong, though this test should remain

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit c9fcba6 into silverstripe:2 Jun 20, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/remove-legacy branch June 20, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants