Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue Master Branch Commit ENH Prefer ::class syntax over class strings #372

Conversation

GuySartorelli
Copy link
Member

Rescues and extends 43be1a0

There's no change to API here so it makes sense to target 1 so both major lines can benefit.

Parent issue

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite different from the rescued commit?

@GuySartorelli
Copy link
Member Author

This PR rescues "and expands upon" the original PR.
I cherry-picked in the commit from the original PR and then looked for instances of what the original commit was doing which had been either missed or added since the original commit was created. The PR would be incomplete if these additional items were left unchanged, since the purpose is to update the old hardcoded string syntax.

lang/en.yml Outdated Show resolved Hide resolved
@GuySartorelli GuySartorelli force-pushed the pulls/1/rescue-master-use-class-syntax branch from 1f76584 to 1a233ce Compare August 31, 2022 22:51
@emteknetnz emteknetnz merged commit 6ebbc7d into silverstripe:1 Sep 1, 2022
@emteknetnz emteknetnz deleted the pulls/1/rescue-master-use-class-syntax branch September 1, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants