Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] API phpunit 9 support #338

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 22, 2021

Issue silverstripe/silverstripe-framework#10019

Currently required for framework on travis to run

Note: there's an equivalent branch on the silverstripe account because travis doesn't like pulling from non silverstripe repos defined in composer.json "repositories". This branch will be deleted once this approach has been proven to work

This PR and the branch on the silverstripe are likely to get out of sync

@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch 18 times, most recently from cfef4f1 to 22f108a Compare October 17, 2021 23:40
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 22f108a to 0ec2ede Compare October 18, 2021 20:50
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 00:59
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 0ec2ede to 63116bb Compare October 27, 2021 04:47
composer.json Outdated Show resolved Hide resolved
tests/php/ChangeSetTest.php Outdated Show resolved Hide resolved
tests/php/ChangeSetTest.php Outdated Show resolved Hide resolved
tests/php/ChangeSetTest.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 63116bb to 0f2b054 Compare October 27, 2021 21:38
@emteknetnz emteknetnz force-pushed the pulls/1/sapphire-test-nine branch from 0f2b054 to 9b39e92 Compare November 1, 2021 01:35
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green!

@maxime-rainville maxime-rainville merged commit 775371a into silverstripe:1 Nov 1, 2021
@maxime-rainville maxime-rainville deleted the pulls/1/sapphire-test-nine branch November 1, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants