FIX Remove legacy sprintf style translations in favour of placeholders #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbieaverill can you please rebase. |
robbieaverill
force-pushed
the
bugfix/remove-sprintf-in-translations
branch
from
cb6d9f1 to
44b86e9
Compare
|
@tractorcow rebased, thanks |
robbieaverill
force-pushed
the
bugfix/remove-sprintf-in-translations
branch
from
44b86e9 to
ab9ec3c
Compare
robbieaverill
force-pushed
the
bugfix/remove-sprintf-in-translations
branch
from
ab9ec3c to
aa93194
Compare
tractorcow
suggested changes
Jul 30, 2017
| @@ -172,7 +172,7 @@ public function doUnpublish($data, $form) | |||
| $record->doUnpublish(); | |||
|
|
|||
| $message = sprintf( | |||
| _t('SilverStripe\\Versioned\\VersionedGridFieldItemRequest.Unpublished', 'Unpublished %s %s'), | |||
There was a problem hiding this comment.
Need to replace sprintf() with the parameterised form of _t() call.
robbieaverill
force-pushed
the
bugfix/remove-sprintf-in-translations
branch
from
aa93194 to
43be1a0
Compare
tractorcow
approved these changes
Jul 30, 2017
|
@tractorcow this was merged into |
|
@flamerohr FYI the other PRs are all in master too |
|
I'll merge them back before tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: silverstripe/silverstripe-framework#6582