FIX Use get_one_by_stage when fetching SiteTree for a specific stage #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
suggested changes
Aug 22, 2018
| protected static $fixture_file = 'HistoryControllerFactoryTest.yml'; | ||
|
|
||
| protected static $illegal_extensions = [ | ||
| HistoryControllerFactory::class => ['DNADesign\Elemental\Extensions\HistoryControllerFactoryExtension'] |
There was a problem hiding this comment.
I think we should just remove every extension on this rather than individual ones. Other modules could have interfered with this as well, we ideally want to clear the global state and isolate it with your stub extension below right?
protected static $illegal_extensions = [
HistoryControllerFactory::class => '*',
];There was a problem hiding this comment.
Ideally yes - all extensions are bad but the TestOnly one. I didn't even know that you could use '*'.
| @@ -0,0 +1,14 @@ | |||
| <?php | |||
| namespace SilverStripe\AssetAdmin\Tests\Controller\HistoryControllerFactory; | |||
There was a problem hiding this comment.
The package name is wrong
| { | ||
| public function updateIsEnabled($record) | ||
| { | ||
| return $record->Title === '2'; |
There was a problem hiding this comment.
Can you add a comment that this is referring to HistoryControllerFactoryTest.yml fixtures?
ScopeyNZ
force-pushed
the
pulls/1.0/stage-fright
branch
from
44bd485 to
45b4980
Compare
ScopeyNZ
force-pushed
the
pulls/1.0/stage-fright
branch
from
45b4980 to
6be253c
Compare
|
Made the suggested changes 🙂 |
robbieaverill
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble reproducing this using the steps that @Cheddam provided but I managed to reproduce it consistently with a test (that I've added to this commit). Yay for TDD!
Resolves #51