Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Update method signature for test class #357

Merged

Conversation

GuySartorelli
Copy link
Member

@@ -41,7 +41,7 @@ public function getMimeType()
return 'text/html';
}

public function CMSEditLink()
public function CMSEditLink(): ?string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function CMSEditLink(): ?string
public function getCMSEditLink(): ?string

@@ -28,7 +28,7 @@ public function getMimeType()
return 'text/html';
}

public function CMSEditLink()
public function CMSEditLink(): ?string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function CMSEditLink(): ?string
public function getCMSEditLink(): ?string

@@ -35,7 +35,7 @@ public function getMimeType()
return 'text/html';
}

public function CMSEditLink()
public function CMSEditLink(): ?string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function CMSEditLink(): ?string
public function getCMSEditLink(): ?string

@GuySartorelli GuySartorelli force-pushed the pulls/3/standardise-cmseditlink branch from b408235 to 7f941a3 Compare August 22, 2024 23:40
@emteknetnz emteknetnz merged commit 9aa5941 into silverstripe:3 Aug 25, 2024
12 checks passed
@emteknetnz emteknetnz deleted the pulls/3/standardise-cmseditlink branch August 25, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants