DOCS additional note to keeping uploaded files secure #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2020 15:51
Touching up the documentation for userforms to advise how uploaded files can be kept secure. Related (but does not address) silverstripe#927
|
I think we should implement #934 instead of pointing out that conceptual flaw in the docs :) |
|
Arguably, the docs (userhelp and technical) are pointing this out already. I've just tried to wrap a little more context around this so readers understand the impact and a recommended action. |
|
OK, I'll merge this - the follow up issue already contains a note that we need to adjust the docs once that bad default is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touching up the documentation to advise how uploaded files can be kept secure.
Related (but does not address) #927