MNT Fix behat test #1342
Closed
MNT Fix behat test #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
force-pushed
the
pulls/7/fix-test
branch
from
4890ba2 to
7393c51
Compare
emteknetnz
force-pushed
the
pulls/7/fix-test
branch
from
7393c51 to
46d9b46
Compare
10 tasks
emteknetnz
force-pushed
the
pulls/7/fix-test
branch
from
46d9b46 to
c30a8a4
Compare
|
That exact test is failing in this PR lol - just with a different reason. Looks like this PR isn't doing what it was intended to do. |
|
Have rerun, tests are passing |
|
It's an intermittent failure - rerunning it almost always makes it pass. I don't think this PR is improving anything and won't merge without evidence that it does. |
|
Intermittent failures are usually timing related. I've made an adjustment to adjust the timing. We use 'wait for x seconds' it lots of other places to fix this sort of thing. Seems like this is an appropriate fix? |
|
The same test failed in this very PR, so it seems to me that the intermittent failure will persist. |
|
Reran userforms CI, didn't experience issue. Will close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11403
Fixes sporadic behat test failure - https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/11562835944/job/32184895385
I dismiss all toasts ... element not interactable