DEP PHP Support in CMS5

[sabina-talipova]

Parent issue

• PHP Support in CMS5 silverstripe-framework#10402

[sabina-talipova]

@emteknetnz , there are some issues with recent changes to DataObject to support php 8.2 https://github.com/silverstripe/silverstripe-framework/blob/c1a773310d088b22bea7ae1a6e1930050f0a33e2/src/ORM/DataObject.php#L2854

I would like to clarify whether we can change the access modifier from private to protected for setFieldValue method, since those classes that inherit DataObject and have this FieldValue field try to call a method to which they do not have access?

Thank you in advance :)

[emteknetnz]

I think that's probably the wrong solution, looks like it's coming from this in framework

ViewableData

    public function __set($property, $value)
    {
        $this->objCacheClear();
        if ($this->hasMethod($method = "set$property")) { // <<< here
            $this->$method($value);
        } else {
            $this->setField($property, $value);
        }
    }

I'm asumming it's trying to set the property 'FieldValue' and it seems the 'setFieldValue' method on DataObject and trys to use that, though that method does something different

I think we need to add an an && isAccessible($method) check in ViewableData::__set() for this edge case

Can you confirm that this unit test is trying to set a $property of 'FieldValue' and then try updating ViewableData::__set() on your local?

[sabina-talipova]

Can you confirm that this unit test is trying to set a $property of 'FieldValue' and then try updating ViewableData::__set() on your local?

@emteknetnz, if you check this line in GA tests https://github.com/silverstripe/silverstripe-userforms/actions/runs/3870193575/jobs/6596921118#step:12:75 , you will see that tests are failed exactly in this if condition in ViewableData class in public function __set($property, $value) method.
https://github.com/silverstripe/silverstripe-framework/blob/0d3953ba3b016b7343edc7369ddc88c54e7755c0/src/View/ViewableData.php#L158-L159.
So it means it runs setFieldValue method that doesn't exist or accessible in class that extends DataObject.
It's probably, something weird, but method_exists function returns true for private parent methods in DataObject.
But it shouldn't https://www.php.net/manual/en/function.method-exists.php.
But is_callable returns false for private methods.
Probably, something wrong in this note https://www.php.net/manual/en/function.method-exists.php#124462

[emteknetnz]

Try adding is_callable() in ViewableData::__set() locally - if that works then open up a PR to framework

[sabina-talipova]

Try adding is_callable() in ViewableData::__set() locally - if that works then open up a PR to framework

Yes, it does.

[sabina-talipova]

Passed tests in local env. Requires PR silverstripe/silverstripe-framework#10637

[sabina-talipova]

Failed Behat tests are related to the issue silverstripe/silverstripe-framework#10645

[maxime-rainville]

LGTM