Upgrading to new version breaks the module.

[sktzoootech]

Upgrading userforms module is not a replace the module and do a dev/build process.  No problem if you haven't defined forms from the old module. In the old userforms module there are 2 fields that doesn't exists anymore in the new one but is somehow still referred to by workflow causing a field doesn't exists error. So what I did to resolve the issue is to backup EditableFormField tables (includes live and versions), delete the tables and do a dev/build with the new userforms module. Restored the tables on a temporary tables and did a selective insert intos.

The above process works and was ok but is there a better way of dealing with this issue?

[wilr]

Which two fields caused you issues? We should clean up those form fields in EditableFormField::requireDefaultRecords() so that it's run on dev/build

[sktzoootech]

It's "CanDelete" and "ShowOnLoad" fields. So does this mean revision on the userforms module adding a clean up process in EditableFormField::requireDefaultRecords()?

[sktzoootech]

I still couldn't visualise the clean up process using requireDefaultRecords. Can you elaborate your proposal? I mean I would really love to do a pull request. :)

[wilr]

Ah didn't see that contrydropdown had been removed (was done by another dev). It's just been added back in so you shouldn't need any DB migrations for upgrade from the latest 2.4 version to 3.0 / 3.1 version.

For DB clean up processes you can either do it in 2 places, requireDefaultRecords() (which is run on DB build) or a custom BuildTask (which has to be run manually at dev/tasks/DoMyTask). As requireDefaultRecords() is run on dev/build it's normally easier for the user. You can do any PHP method you want in there e.g

function requireDefaultRecords() {
parent::requireDefaultRecords();

// run any DB queries or use the ORM to 'clean up' however you want
DB::query("DELETE FROM Page")->execute();
}

But saying that, we shouldn't need a migration?

[sktzoootech]

Thanks Wilr. Yup we don't need to do a migration if that is the case but I appreciate elaborating on the clean up. Cheers.

[kmayo-ss]

opened the following pull request

#129

This adds a task to remove surplus columns from EditableFormField for MySQL databases