Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add missing translation strings to js src lang #123

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jun 13, 2023

These will be migrated into the client/lang/en.js file and pushed to transifex next time translations are run.

The strings were automatically collected (and reordered to alphabetical order by keys) using this POC branch of framework wherein the textcollector is able to fetch strings from javascript.

Issue

@emteknetnz emteknetnz merged commit 73a8d67 into silverstripe:4.6 Jun 13, 2023
@emteknetnz emteknetnz deleted the pulls/4.6/missing-translation-strings branch June 13, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants