Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Update behat tests to support toast messages #97

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova force-pushed the pulls/2.5/test-toast-message branch from e5935c5 to 6a95779 Compare November 7, 2023 02:59
@GuySartorelli
Copy link
Member

Behat tests are failing here

@sabina-talipova sabina-talipova force-pushed the pulls/2.5/test-toast-message branch from 6a95779 to 84fd62b Compare November 7, 2023 03:24
@sabina-talipova
Copy link
Contributor Author

Fixed. All tests are passed.

@sabina-talipova sabina-talipova force-pushed the pulls/2.5/test-toast-message branch from 84fd62b to e130d8d Compare November 7, 2023 20:30
@sabina-talipova sabina-talipova force-pushed the pulls/2.5/test-toast-message branch from e130d8d to 063f75d Compare November 7, 2023 20:32
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit f05d874 into silverstripe:2.5 Nov 12, 2023
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.5/test-toast-message branch November 12, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants