Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary react-select scss import that breaks other CMS styles #225

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

purplespider
Copy link
Contributor

Fixes #211

Before:
Screenshot 2022-12-22 at 10 15 54@2x
Screenshot 2022-12-22 at 10 18 04@2x

After:
Screenshot 2022-12-22 at 10 21 16@2x
Screenshot 2022-12-22 at 10 20 26@2x

@michalkleiner
Copy link
Contributor

How do focused and hovered tags look before and after?

@purplespider
Copy link
Contributor Author

The same as the built in TreeMultiselectField:

Screenshot 2022-12-22 at 10 35 49@2x

And here's the dropdown, again the same as the standard TreeMultiselectField:
Screenshot 2022-12-22 at 10 40 26@2x

@GuySartorelli
Copy link
Member

Seems fine to me but I wouldn't mind someone else giving this a quick once-over in case I have missed something

@purplespider
Copy link
Contributor Author

Good to merge?

@GuySartorelli
Copy link
Member

I was hoping someone else would take a look but it seems like that's not happening so yeah I'll merge.
Thanks for doing this!

@GuySartorelli GuySartorelli merged commit 42cf651 into silverstripe:2 Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks TreeMultiselectField CSS Styles
3 participants