Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Set extension hook implementation visibility to protected #571

Merged
merged 1 commit into from
May 21, 2024
Merged

API Set extension hook implementation visibility to protected #571

merged 1 commit into from
May 21, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 16, 2024 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request May 16, 2024
Closed
3 tasks
@emteknetnz emteknetnz force-pushed the pulls/4/protect-hooks branch from a9f9b63 to c3cf57e Compare May 20, 2024 05:04
@GuySartorelli
Copy link
Member

Still failing after rerunning CI

@emteknetnz emteknetnz force-pushed the pulls/4/protect-hooks branch from c3cf57e to a96000e Compare May 21, 2024 05:16
GuySartorelli
GuySartorelli approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 4bd9be8 into silverstripe:4 May 21, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/protect-hooks branch May 21, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli