Update documentation "Using Subsites in combination with Fluent" part #514
Conversation
…riable is not existing anymore
README.md
Outdated
| *PageController.php* | ||
| ``` | ||
| :::php | ||
| protected function init(){ |
There was a problem hiding this comment.
| protected function init(){ | |
| protected function init() | |
| { |
There was a problem hiding this comment.
Please make this change, so that the documentation is showing best practice.
README.md
Outdated
| When using Subsites in combination with Fluent module, the Subsites module sets the i18n locale to the language defined in the current Subsite. When this behaviour is not desired and you need to use the locale in FluentState use the following setting in your yml config file: | ||
| When using Subsites in combination with Fluent module, the Subsites module sets the i18n locale to the language defined in the current Subsite. When this behaviour is not desired and you need to use the locale in FluentState you can set the current Fluent locale in your PageController like this: | ||
|
|
||
| ```yaml | ||
| SilverStripe\Subsites\Extensions\SiteTreeSubsites: | ||
| ignore_subsite_locale: true | ||
| *PageController.php* | ||
| ``` | ||
| :::php | ||
| protected function init(){ | ||
| if ($this->dataRecord->SubsiteID !== 0){ | ||
| i18n::set_locale(FluentState::singleton()->getLocale()); | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Can you please explain why you're making this change? What was wrong with the yaml configuration documented here?
There was a problem hiding this comment.
I make this change, because the yaml configuration documented is not in use in the Subsite-Module. So even with the yml configuration set, the i18n-Locale is still the one defined for the subsite and not the one from fluent. My solution is just one possible workaround.
There was a problem hiding this comment.
I make this change, because the yaml configuration documented is not in use in the Subsite-Module.
That yaml configuration is used here:
silverstripe-subsites/src/Extensions/SiteTreeSubsites.php
Lines 399 to 417 in 4e292b8
There was a problem hiding this comment.
ah I see - okay. In module version 2.6.0 it wasn't there :). Seems it changed in the meanwhile.
Than my change is unnecessary of course .
There was a problem hiding this comment.
Okay cool. I'll close this PR then. Thank you for your efforts and patience though, it's definitely appreciated.
revert changes as suggested
Revert part 2
last revert
References: #509 - the yml-config solution for setting the Fluent locale instead of the Subsite-locale is not existing anymore. I replaced the old solution with a workaround which works for me.
it's my first PR :)