Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP PHP Support in CMS5 #497

Merged
merged 1 commit into from
Jan 10, 2023
Merged

DEP PHP Support in CMS5 #497

merged 1 commit into from
Jan 10, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Dec 13, 2022
Closed
3 tasks
emteknetnz
emteknetnz requested changes Dec 18, 2022
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing unit tests

@sabina-talipova sabina-talipova force-pushed the pulls/3/upgrade-cs5 branch 12 times, most recently from 0ad5fc8 to 2135fba Compare December 21, 2022 22:55
@sabina-talipova
Copy link
Contributor Author

Tests passed

@sabina-talipova sabina-talipova mentioned this pull request Dec 22, 2022
Merged
@emteknetnz emteknetnz merged commit a67b7ef into silverstripe:3 Jan 10, 2023
@emteknetnz emteknetnz deleted the pulls/3/upgrade-cs5 branch January 10, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @emteknetnz