Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Replace ADMIN permissions with less permissions in Behat test #487

Merged

Conversation

sabina-talipova
Copy link
Contributor

Description

Replace user with "Admin" permissions to user with "Editor" permissions.

Parent issue

Comment on lines 11 to 12
And the "group" "EDITOR" has permissions "Access to 'Pages' section"
And I am logged in as a member of "EDITOR" group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And the "group" "EDITOR" has permissions "Access to 'Pages' section"
And I am logged in as a member of "EDITOR" group
And I am logged in with "CMS_ACCESS_CMSMain" permissions

There's no need to create a group for just the one permission - I am logged in with "CMS_ACCESS_CMSMain" permissions is already correct here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@sabina-talipova sabina-talipova force-pushed the pulls/2/review-behat-tests branch from d7b8989 to 5eb7e8a Compare September 9, 2022 03:17
@GuySartorelli GuySartorelli merged commit 1e311e8 into silverstripe:2 Sep 12, 2022
@GuySartorelli GuySartorelli deleted the pulls/2/review-behat-tests branch September 12, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants