Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX replace in_array check with hasTable check. #476

Merged
merged 1 commit into from
Feb 15, 2022
Merged

FIX replace in_array check with hasTable check. #476

merged 1 commit into from
Feb 15, 2022

Conversation

wilr
Copy link
Member

@wilr wilr commented Feb 15, 2022

in_array is case-sensitive and may not detect that a table exists when using lowercase format

@wilr
FIX replace in_array check with hasTable check.
dfe1ba5 
in_array is case-sensitive and may not detect that a table exists when using lowercase format
@michalkleiner michalkleiner merged commit 5c3d000 into silverstripe:2 Feb 15, 2022
@wilr wilr deleted the wilr-patch-1 branch February 15, 2022 02:46
@wilr
Copy link
Member Author

wilr commented Feb 15, 2022

thanks @michalkleiner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilr @michalkleiner