fixing code analysis: phpunit: use assertInstanceOf

silverstripe · Jun 1, 2017 · 849c006 · 849c006
1 parent 25754e1
commit 849c006
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/tests/php/FileSubsitesTest.php b/tests/php/FileSubsitesTest.php
@@ -39,7 +39,7 @@ public function testTrivialFeatures()
         $this->assertEquals(' * FileTitle', $file->alternateTreeTitle());
         $file->SubsiteID = $this->objFromFixture(Subsite::class, 'domaintest1')->ID;
         $this->assertEquals('FileTitle', $file->getTreeTitle());
-        $this->assertTrue(singleton(Folder::class)->getCMSFields() instanceof FieldList);
+        $this->assertInstanceOf(FieldList::class, singleton(Folder::class)->getCMSFields());
         Subsite::changeSubsite(1);
         $this->assertEquals('subsite-1', $file->getExtensionInstance(FileSubsites::class)->cacheKeyComponent());
     }

diff --git a/tests/php/GroupSubsitesTest.php b/tests/php/GroupSubsitesTest.php
@@ -16,7 +16,7 @@ public function testTrivialFeatures()
     {
         $this->assertTrue(is_array(singleton(GroupSubsites::class)->extraStatics()));
         $this->assertTrue(is_array(singleton(GroupSubsites::class)->providePermissions()));
-        $this->assertTrue(singleton(Group::class)->getCMSFields() instanceof FieldList);
+        $this->assertInstanceOf(FieldList::class, singleton(Group::class)->getCMSFields());
     }
 
     public function testAlternateTreeTitle()

diff --git a/tests/php/SiteTreeSubsitesTest.php b/tests/php/SiteTreeSubsitesTest.php
@@ -67,10 +67,10 @@ public function testPagesInDifferentSubsitesCanShareURLSegment()
 
     public function testBasicSanity()
     {
-        $this->assertTrue(singleton(SiteTree::class)->getSiteConfig() instanceof SiteConfig);
+        $this->assertInstanceOf(SiteConfig::class, singleton(SiteTree::class)->getSiteConfig());
         // The following assert is breaking in Translatable.
-        $this->assertTrue(singleton(SiteTree::class)->getCMSFields() instanceof FieldList);
-        $this->assertTrue(singleton(SubsitesVirtualPage::class)->getCMSFields() instanceof FieldList);
+        $this->assertInstanceOf(FieldList::class, singleton(SiteTree::class)->getCMSFields());
+        $this->assertInstanceOf(FieldList::class, singleton(SubsitesVirtualPage::class)->getCMSFields());
         $this->assertTrue(is_array(singleton(SiteTreeSubsites::class)->extraStatics()));
     }