Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate API that will be removed #203

Merged
merged 1 commit into from
Sep 13, 2024
Merged

API Deprecate API that will be removed #203

merged 1 commit into from
Sep 13, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Sep 10, 2024
Closed
3 tasks
emteknetnz
emteknetnz requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the call to Deprecation::notice() + deprecated annotations

@GuySartorelli
Copy link
Member Author

log() was the only thing deprecated - the withNoReplacement calls all wrap calls to log(). Unless I'm not seeing something? If that's the case please comment on the actual code lines that need to be addressed so I can see what you're seeing.

@GuySartorelli GuySartorelli force-pushed the pulls/6/cms5-for-sakesymfony branch from 0953b95 to 8f841d2 Compare September 12, 2024 21:49
@emteknetnz emteknetnz merged commit d42ca25 into silverstripe:6 Sep 13, 2024
8 checks passed
@emteknetnz emteknetnz deleted the pulls/6/cms5-for-sakesymfony branch September 13, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz