Configurable fieldname #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
previously requested changes
Aug 23, 2017
| @@ -74,6 +74,8 @@ public function enableSpamProtection($options = array()) | |||
| // captcha form field name (must be unique) | |||
| if (isset($options['name'])) { | |||
| $name = $options['name']; | |||
| } else if($field_name = Config::inst()->get('FormSpamProtectionExtension', 'field_name')) { | |||
There was a problem hiding this comment.
Can you please add the private static $field_name = 'Captcha'; to this class, then you can have one fewer condition. :)
|
Yep, done! |
dhensby
approved these changes
Aug 24, 2017
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for a configurable field name to be used as the name of the spam protection field.
Some modules create fields without a 'name' defined in enableSpamProtection() - resulting in the fieldname being "Captcha" which could be detected by spam bots and ignored. Allowing a configurable, nondescript field name would reduce the risk of that occurring.