API Refactor for removal of CMSForm class #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tractorcow
force-pushed
the
pulls/4.0/schema-api
branch
4 times, most recently
from
02343a0 to
6a94e59
Compare
|
I think this needs the same fix as CMS - we need to declare the phpunit dev dependency explicitly otherwise it takes 3.7, which in turn isn't compatible with the Behat module that's compatible with 4.x... |
tractorcow
force-pushed
the
pulls/4.0/schema-api
branch
from
6a94e59 to
bb121cf
Compare
|
Yeah I'm doing it lol. |
|
I've sent a similar fix for PHPUnit to silverstripe/silverstripe-reports#27 |
tractorcow
force-pushed
the
pulls/4.0/schema-api
branch
from
bb121cf to
ae221c9
Compare
tractorcow
force-pushed
the
pulls/4.0/schema-api
branch
from
ae221c9 to
14d74f7
Compare
|
GREEN |
|
MERGED |
chillu
added a commit
that referenced
this pull request
Mar 7, 2016
API Refactor for removal of CMSForm class
| @@ -10,8 +10,8 @@ | |||
| "require": { | |||
| "silverstripe/framework": "^4.0" | |||
| }, | |||
| "extra": { | |||
| "installer-name": "siteconfig" | |||
There was a problem hiding this comment.
What was the reasoning behind removing this?
There was a problem hiding this comment.
extra was duplicated in composer.json and was being ignored. Look down the file a bit...
Also it's not needed. silverstripe/siteconfig is already named as siteconfig and doesn't need an alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix tests at silverstripe/silverstripe-cms#1410