Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #182

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions code/SiteConfigPagePermissions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class SiteConfigPagePermissions implements DefaultPermissionChecker
* @param Member $member
* @return bool
*/
public function canEdit(Member $member = null)
public function canEdit(?Member $member = null)
{
return SiteConfig::current_site_config()->canEditPages($member);
}
Expand All @@ -27,7 +27,7 @@ public function canEdit(Member $member = null)
* @param Member $member
* @return bool
*/
public function canView(Member $member = null)
public function canView(?Member $member = null)
{
return SiteConfig::current_site_config()->canViewPages($member);
}
Expand All @@ -38,7 +38,7 @@ public function canView(Member $member = null)
* @param Member $member
* @return bool
*/
public function canDelete(Member $member = null)
public function canDelete(?Member $member = null)
{
// Same as canEdit
return $this->canEdit($member);
Expand All @@ -50,7 +50,7 @@ public function canDelete(Member $member = null)
* @param Member $member
* @return bool
*/
public function canCreate(Member $member = null)
public function canCreate(?Member $member = null)
{
return SiteConfig::current_site_config()->canCreateTopLevel();
}
Expand Down
Loading