API phpunit 9 support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
4 times, most recently
from
cba68d0 to
774b5ea
Compare
maxime-rainville
requested changes
Nov 1, 2021
.travis.yml
Outdated
Comment on lines
10
to
11
| - php: 7.4 | ||
| env: PHPUNIT_TEST=1 |
There was a problem hiding this comment.
Suggested change
| - php: 7.4 | |
| env: PHPUNIT_TEST=1 | |
| - php: 7.4 | |
| env: PHPUNIT_TEST=1 | |
| - php: 8.0 | |
| env: PHPUNIT_TEST=1 |
If you want to go a step beyond, you could remove the PHPUNIT_TEST env var altogether and always run the build.
composer.json
Outdated
| @@ -3,23 +3,18 @@ | |||
| "description": "Connects the PHP development server to SilverStripe", | |||
| "license": "MIT", | |||
| "require": { | |||
| "php": "^5.6||^7.0", | |||
| "php": "^7.3", | |||
There was a problem hiding this comment.
Suggested change
| "php": "^7.3", | |
| "php": "^7.3 || ^8.0", |
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
774b5ea to
1939528
Compare
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
1939528 to
9ad015f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10019