Feat(Attribute Mapping): Allow the use of opt in GUID/nameid as attribute. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as an example this new setting in combination with the following: SilverStripe\SAML\Extensions\SAMLMemberExtension:
claims_field_mappings:
'GUID' => 'Email'would map GUID/nameid to email. |
|
CI Failing due to some composer stuff n things. I had a look over @ silverstripe/silverstripe-cms and they were talking about some change to shared config. Don't think I need to do anything here. EDIT: Looks like CI has been failing for a while due the composer stuff and has nothing to do with the travis changes mentioned above. |
madmatt
approved these changes
May 10, 2022
|
Merging despite Travis errors as they are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be great for our use case, We are happy to work out a hack using the extension point if that is deemed more ideal.
Weird use case but I've seen it used before eg. MOODLE's main SAML authentication plugin explains it well.
Ideally this sort of thing gets dealt with on the IdP side but they don't always want to work with you 😄