New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support backticked environment variables in saml config #35

Merged

madmatt merged 1 commit into silverstripe:master from ishannz:pulls/allow-backticked-env-variables

Mar 24, 2022

Contributor

ishannz commented Mar 14, 2022 •

edited by dhensby

Loading

Current Issue: environment variables not supported in the SAML config

Fix: User can use environment variables inside the yml SAML config like this,

SilverStripe\SAML\Services\SAMLConfiguration:
  strict: true
  debug: false
  SP:
    entityId: '`SP_ENTITY_ID`'
    privateKey: '`SP_PRIVATE_KEY_PATH`'
    x509cert: '`SP_PUBLIC_KEY_PATH`'
  IdP:
    entityId: '`IDP_ENTITY_ID`'
    x509cert: '`IDP_PUBLIC_KEY_PATH`'
    singleSignOnService: '`IDP_SSO_SERVICE`'


          Support backticked environment variables in saml config

b79a45f

Member

madmatt commented Mar 24, 2022

Looks good to me, thanks @ishannz!

madmatt merged commit acf2eef into silverstripe:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet