Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: developer docs - incorrect description how to disable sending AuthN context #26

Merged
merged 1 commit into from
Jun 25, 2019
Merged

FIX: developer docs - incorrect description how to disable sending AuthN context #26

merged 1 commit into from
Jun 25, 2019

Conversation

JakubDolba
Copy link
Contributor

this misleading doc case undesirable behavior by sending default AuthN Context in SAML Request

robbieaverill
robbieaverill reviewed Jun 25, 2019
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the logic in the code more closely. I'd suggest you could also document that using authn_contexts: false will provide a set of default contexts, but not a blocker for this PR. Thanks.

@robbieaverill robbieaverill merged commit 28cef18 into silverstripe:master Jun 25, 2019
@JakubDolba JakubDolba deleted the fix/missleading-docs branch June 25, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill left review comments

Assignees
No one assigned
Labels
affects/v4 type/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakubDolba @robbieaverill