Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: creating LoginForm from Authenticator #24

Merged
merged 1 commit into from
Jun 20, 2019
Merged

FIX: creating LoginForm from Authenticator #24

merged 1 commit into from
Jun 20, 2019

Conversation

JakubDolba
Copy link
Contributor

  • missing arguments and arguments mismatch when creating SamlLoginForm from SamlAuthenticator
  • adding a phpdoc note about unused constructor argument

robbieaverill
robbieaverill approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@robbieaverill robbieaverill force-pushed the fix/login-form-arguments branch from 5b02a3c to 152d605 Compare June 20, 2019 03:51
@robbieaverill
Copy link
Contributor

Rebased to fix build issue

@robbieaverill
Copy link
Contributor

I'll fix the other build separately, thanks

@robbieaverill robbieaverill merged commit d98ed4e into silverstripe:master Jun 20, 2019
@JakubDolba JakubDolba deleted the fix/login-form-arguments branch June 20, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4 change/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakubDolba @robbieaverill