Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect guid validation #22

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Fix incorrect guid validation #22

merged 2 commits into from
Jun 13, 2019

Conversation

JakubDolba
Copy link
Contributor

this resolves #19

  • possible BC break if someone rely on allowing only uppercase guid

@JakubDolba JakubDolba mentioned this pull request Jun 13, 2019
Closed
@JakubDolba
Copy link
Contributor Author

just found that there are tests for SAMLHelper - I will add test cases for this

@JakubDolba JakubDolba force-pushed the fix/invalid-guid-validation branch from 6365a18 to 0b2adbc Compare June 13, 2019 03:27
@robbieaverill robbieaverill merged commit 0bd0180 into silverstripe:master Jun 13, 2019
@JakubDolba JakubDolba deleted the fix/invalid-guid-validation branch June 13, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
affects/v4 change/patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUID validation is incorrect
2 participants
@JakubDolba @robbieaverill