-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Migrate code from other modules #204
NEW Migrate code from other modules #204
Conversation
c8b68d3
to
50c0426
Compare
50c0426
to
f0143d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The external broken links report doesn't work. I click "create new report" and it does nothing. Looking at the dev console there are some missing files. I think you're missing the expose
entry for client/dist
in composer.json
The folder structure between the newly copied code is also not standardised. e.g. ExternalLinks
has a Reports
subfolder, but the other two don't. Please make the folder structure uniform across all three feature dirs.
f0143d6
to
f098132
Compare
f098132
to
e6c2678
Compare
Works fine on my local
Have updated |
Ignore me, it works fine, I just was pulling it in wrong |
Have moved docs for external links + site wide content report do docs/en/index.md |
9d20a91
to
d1913b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue silverstripe/.github#342
Separate commits so please do no squash merge
Code copied from silverstripe/securityreport has had any code relating to subsites removed
Any code that was relating to silverstripe/subsites or silverstripe/contentreport has been removed as those module will not be commercially supported going forward