Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Migrate code from other modules #204

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 20, 2024

Issue silverstripe/.github#342

Separate commits so please do no squash merge

Code copied from silverstripe/securityreport has had any code relating to subsites removed

Any code that was relating to silverstripe/subsites or silverstripe/contentreport has been removed as those module will not be commercially supported going forward

@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch 10 times, most recently from c8b68d3 to 50c0426 Compare November 20, 2024 03:15
@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from 50c0426 to f0143d6 Compare November 20, 2024 05:56
@emteknetnz emteknetnz marked this pull request as ready for review November 26, 2024 04:32
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external broken links report doesn't work. I click "create new report" and it does nothing. Looking at the dev console there are some missing files. I think you're missing the expose entry for client/dist in composer.json

The folder structure between the newly copied code is also not standardised. e.g. ExternalLinks has a Reports subfolder, but the other two don't. Please make the folder structure uniform across all three feature dirs.

tests/behat/src/FeatureContext.php Outdated Show resolved Hide resolved
client/src/styles/sitewidecontentreport.scss Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from f0143d6 to f098132 Compare November 27, 2024 01:08
@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from f098132 to e6c2678 Compare November 27, 2024 01:11
@emteknetnz
Copy link
Member Author

The external broken links report doesn't work. I click "create new report" and it does nothing. Looking at the dev console there are some missing files. I think you're missing the expose entry for client/dist in composer.json

Works fine on my local

The folder structure between the newly copied code is also not standardised. e.g. ExternalLinks has a Reports subfolder, but the other two don't. Please make the folder structure uniform across all three feature dirs.

Have updated

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 27, 2024

External broken links report still doesn't work for me. I'm just using installer (not sink) and pulling in only this PR since it shouldn't rely on any of the other changes from what I can tell.

Ignore me, it works fine, I just was pulling it in wrong

README.md Outdated Show resolved Hide resolved
@emteknetnz
Copy link
Member Author

Have moved docs for external links + site wide content report do docs/en/index.md

@emteknetnz emteknetnz force-pushed the pulls/6/remove-support branch from 9d20a91 to d1913b0 Compare November 27, 2024 22:25
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 579b939 into silverstripe:6 Nov 28, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-support branch November 28, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants