ENH Prefer dependency injection for GridFieldComponents #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
2 times, most recently
from
28df268 to
c85b99d
Compare
emteknetnz
requested changes
Mar 3, 2022
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
c85b99d to
9eecdae
Compare
|
@emteknetnz Done! |
|
You'll need to rebase @GuySartorelli |
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
9eecdae to
f9ba02e
Compare
|
@emteknetnz Oops, good note. Rebased on 4. |
emteknetnz
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0 (see silverstripe/silverstripe-framework#10204)
Explicitly invoking the injector here instead of using create() allows backwards compatability with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.
See silverstripe/silverstripe-admin#1286 for (brief) discussion of this approach vs using
::create().