Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Rescue Master Branch PR: Update PostgreSQLQuery to use generators #135

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Aug 11, 2022

Rescues #84 from the master branch.
Requires silverstripe/silverstripe-framework#10450 to be merged before the tests can go green.

Parent Issue

@GuySartorelli GuySartorelli marked this pull request as draft August 11, 2022 03:30
@GuySartorelli GuySartorelli changed the title API Update PostgreSQLQuery to use generators API Rescue Master Branch PR: Update PostgreSQLQuery to use generators Aug 23, 2022
@emteknetnz
Copy link
Member

@GuySartorelli Am re-running tests after merging the framework PR

@GuySartorelli GuySartorelli force-pushed the pulls/3/rescue-master-generators branch from c01dd6a to 5c07020 Compare August 29, 2022 23:34
@GuySartorelli GuySartorelli marked this pull request as ready for review August 29, 2022 23:34
@GuySartorelli
Copy link
Member Author

Rebased to get correct PHP versions in CI.

@emteknetnz emteknetnz merged commit 0c2d674 into silverstripe:3 Aug 31, 2022
@emteknetnz emteknetnz deleted the pulls/3/rescue-master-generators branch August 31, 2022 21:08
@GuySartorelli GuySartorelli restored the pulls/3/rescue-master-generators branch September 2, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants