BUG Fix issues preventing a site from being migrated from SS3 to SS4 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because backslashes were not accounting
maxime-rainville
force-pushed
the
pulls/2/fix-classname
branch
from
95ff154 to
fa7ac8b
Compare
maxime-rainville
commented
Sep 6, 2019
1 task
maxime-rainville
commented
Sep 6, 2019
maxime-rainville
commented
Sep 6, 2019
maxime-rainville
force-pushed
the
pulls/2/fix-classname
branch
from
71b933f to
74a20c0
Compare
maxime-rainville
commented
Sep 9, 2019
maxime-rainville
commented
Sep 9, 2019
|
Added unit tests. This is ready for review. Note that after upgrading you table, you can actually put whatever value you want in the ClassName table. I've raised a bug about this #105 |
ScopeyNZ
reviewed
Sep 9, 2019
dnsl48
suggested changes
Sep 20, 2019
dnsl48
reviewed
Sep 23, 2019
dnsl48
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. I fix the initial problem that prevented ClassNames from being migrated.
But there'smore problems with Versioned tables ClassName columns ... and potentially with Polymorphic relationships.
Parent issue
classname_value_remappingfails when upgrading a SilverStripe 3 project to 4 on PostgreSQL silverstripe-framework#8344