Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Change favicon to reflect new logo #358

Merged

Conversation

maxime-rainville
Copy link
Contributor

Change the favicon.

Note that people upgrading a existing project, won't get the new favicon.

Also the file size of the new logo is quite bit bigger because it's much higher resolution.

Parent issue

silverstripe/silverstripe-admin#1542

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is fine though don't merge until had had design review

@maxime-rainville maxime-rainville merged commit 6b5a78b into silverstripe:5 Aug 24, 2023
@maxime-rainville maxime-rainville deleted the pulls/5/new-logo branch August 24, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants