Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Set PHP 7.4 as the minimum version #315

Merged
merged 1 commit into from
Mar 7, 2022
Merged

DEP Set PHP 7.4 as the minimum version #315

merged 1 commit into from
Mar 7, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Feb 10, 2022
Closed
86 tasks
maxime-rainville
maxime-rainville reviewed Feb 18, 2022
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing but it seems unrelated to this change. I just restarted the build just to double check it's not gobblins

@emteknetnz
Copy link
Member Author

Attempting to fix the broken behat test in admin with this PR silverstripe/silverstripe-admin#1290

@maxime-rainville
Copy link
Contributor

Pr has been merged re-running now.

@maxime-rainville
Copy link
Contributor

Behat is grumpy for some reason

@emteknetnz
Copy link
Member Author

@maxime-rainville behat issue is pre-existing

@maxime-rainville
Copy link
Contributor

Merged. We'll aim to fix the behat issue independantly

@maxime-rainville maxime-rainville deleted the pulls/4/php74 branch March 7, 2022 03:09
@maxime-rainville maxime-rainville restored the pulls/4/php74 branch March 7, 2022 03:09
@maxime-rainville
Copy link
Contributor

Hit the wrong button!

maxime-rainville
maxime-rainville approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve despite broken build. We'll fix interdependently.

@maxime-rainville maxime-rainville merged commit 567236f into silverstripe:4 Mar 7, 2022
@maxime-rainville maxime-rainville deleted the pulls/4/php74 branch March 7, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @maxime-rainville