Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit 9 support #310

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch 2 times, most recently from 6c3f8f6 to 35f32d1 Compare October 20, 2021 23:17
@emteknetnz emteknetnz force-pushed the pulls/4/sapphire-test-nine branch from 35f32d1 to 54a8b8c Compare November 3, 2021 22:13
@emteknetnz emteknetnz marked this pull request as ready for review November 3, 2021 22:16
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... just restarted the build

@emteknetnz
Copy link
Member Author

Broken on graphql4 asset-admin behat test - however this isn't related to this PR

We should merge this PR as is

@maxime-rainville maxime-rainville merged commit e48b166 into silverstripe:4 Nov 10, 2021
@maxime-rainville maxime-rainville deleted the pulls/4/sapphire-test-nine branch November 10, 2021 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants