FIX Update CMS fields now that they're being scaffolded #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Aug 11, 2024
Comment on lines
+80
to
+78
| $fields->dataFieldByName('BottomContent')?->addExtraClass('stacked'); | ||
| $fields->dataFieldByName('AlternateContent')?->addExtraClass('stacked'); |
There was a problem hiding this comment.
Intentionally made these wider, because it was silly how much space was being wasted
GuySartorelli
commented
Aug 11, 2024
| $contentField = $fields->dataFieldByName('Content'); | ||
| if ($contentField) { | ||
| $fields->removeByName('Content'); | ||
| $contentField->setTitle(_t(__CLASS__ . '.db_Content', 'Content (appears above iframe)')); |
There was a problem hiding this comment.
fieldLabel() only takes the class where the field is defined into account, not the class where it's being called from, so we can't just rely on $this->fieldLabel('Content') here like we normally would.
GuySartorelli
force-pushed
the
pulls/4/scaffold-sitetree
branch
from
23f0069 to
9413093
Compare
GuySartorelli
commented
Aug 12, 2024
There was a problem hiding this comment.
See silverstripe/silverstripe-cms#2983 (comment) about translation strings.
emteknetnz
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes to
SiteTreein silverstripe/silverstripe-cms#2983Issue