Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Use SS_List as type #612

Merged
merged 1 commit into from
Oct 30, 2024
Merged

API Use SS_List as type #612

merged 1 commit into from
Oct 30, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 21, 2024
Closed
5 tasks
@emteknetnz emteknetnz marked this pull request as draft October 21, 2024 05:59
@emteknetnz emteknetnz force-pushed the pulls/6/ss-list-combine branch from 2d4be15 to ee9b3f8 Compare October 22, 2024 23:06
@emteknetnz emteknetnz marked this pull request as ready for review October 24, 2024 05:49
GuySartorelli
GuySartorelli approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when framework PR is merged

@GuySartorelli GuySartorelli merged commit 7f5c6e4 into silverstripe:6 Oct 30, 2024
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/ss-list-combine branch October 30, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli