Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH add canInit method and CAN_DEV_GRAPHQL permissions #559

Merged
merged 2 commits into from
Nov 10, 2023
Merged

ENH add canInit method and CAN_DEV_GRAPHQL permissions #559

merged 2 commits into from
Nov 10, 2023

Conversation

andrewandante
Copy link
Contributor

@andrewandante andrewandante commented Oct 19, 2023 •
edited by GuySartorelli
Loading

@andrewandante andrewandante mentioned this pull request Oct 19, 2023
Closed
@andrewandante andrewandante marked this pull request as ready for review October 19, 2023 09:24
@andrewandante
Copy link
Contributor Author

Test failures are for a missing method that's contained in the companion PR: DevelopmentAdmin::permissionsCategory()

GuySartorelli
GuySartorelli reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this will require a method that doesn't exist until framework 5.2, we need to bump the dependency in composer.json

@andrewandante andrewandante force-pushed the ENH/add_dev_permission branch from 4b07754 to 997cbe6 Compare October 19, 2023 21:00
GuySartorelli
GuySartorelli requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also apply any relevant feedback from the framework PR.

src/Dev/DevelopmentAdmin.php Outdated Show resolved Hide resolved
@andrewandante andrewandante force-pushed the ENH/add_dev_permission branch from c17d74f to 4cb03f3 Compare October 26, 2023 21:47
@andrewandante andrewandante force-pushed the ENH/add_dev_permission branch from 4cb03f3 to addf529 Compare October 26, 2023 23:38
@andrewandante andrewandante mentioned this pull request Oct 26, 2023
Merged
GuySartorelli
GuySartorelli approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected. Will merge when the framework PR has been merged.

@GuySartorelli
Copy link
Member

Rerunning CI - will merge on green

@GuySartorelli GuySartorelli merged commit 4192aa4 into silverstripe:5 Nov 10, 2023
12 checks passed
@andrewandante andrewandante deleted the ENH/add_dev_permission branch November 10, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewandante @GuySartorelli