Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix unit test #551

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 24, 2023

Issue silverstripe/.github#101

This particular unit test failure was only seen on silverstripe/installer recipe-kitchen-sink as it requires the silverstripe/admin test UsedOnTableTest::getUsage() to run first and cache some config before running this test

@emteknetnz emteknetnz force-pushed the pulls/4.3/config-locator branch from 62f95ea to de8d463 Compare August 24, 2023 07:24
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest using Injector::inst()->registerService() instead but given the end result would be the same and there's a big comment explaining what's happening I'm fine with this approach.

@GuySartorelli GuySartorelli merged commit 868bf6a into silverstripe:4.3 Aug 27, 2023
@GuySartorelli GuySartorelli deleted the pulls/4.3/config-locator branch August 27, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants