Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit 9 support #410

Merged
merged 1 commit into from
Nov 2, 2021
Merged

API phpunit 9 support #410

merged 1 commit into from
Nov 2, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 13, 2021
Closed
93 tasks
@emteknetnz emteknetnz force-pushed the pulls/master/sapphire-test-nine branch 5 times, most recently from 4e02e69 to 96f2fbd Compare October 20, 2021 00:28
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 01:00
@emteknetnz emteknetnz force-pushed the pulls/master/sapphire-test-nine branch from 96f2fbd to c4e3d92 Compare October 27, 2021 04:53
maxime-rainville
maxime-rainville requested changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want a PHP8 build. Even if it's not PHP8-compatible yet, let's maybe merge it broken so we can see that work is needed.

.travis.yml Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/master/sapphire-test-nine branch from c4e3d92 to 20bff97 Compare October 27, 2021 22:41
unclecheese
unclecheese approved these changes Nov 1, 2021
View reviewed changes
Copy link

@unclecheese unclecheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maxime-rainville
maxime-rainville reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing linting and behat test, but those failures look pre-existing. PHP8 builds are happy at least. I'm happy to merge as is since this is technically still in alpha and the failures are pre-existing.

maxime-rainville
maxime-rainville requested changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PostgreSQL build is no longer running.

image

@emteknetnz emteknetnz force-pushed the pulls/master/sapphire-test-nine branch from 20bff97 to e060705 Compare November 2, 2021 01:53
@emteknetnz
Copy link
Member Author

Oh right, master branch has a custom matrix. Have added PGSQL to it.

maxime-rainville
maxime-rainville approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tho other two failures are pre-existing.

@maxime-rainville maxime-rainville merged commit 37a5b86 into silverstripe:master Nov 2, 2021
@maxime-rainville maxime-rainville deleted the pulls/master/sapphire-test-nine branch November 2, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

@unclecheese unclecheese unclecheese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @unclecheese @maxime-rainville