API phpunit9 support #409
Merged
API phpunit9 support #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
emteknetnz
force-pushed
the
pulls/3/sapphire-test-nine
branch
8 times, most recently
from
50d4474 to
cfcab57
Compare
emteknetnz
force-pushed
the
pulls/3/sapphire-test-nine
branch
7 times, most recently
from
9e2410c to
cd1912a
Compare
maxime-rainville
requested changes
Oct 27, 2021
composer.json
Outdated
| @@ -17,8 +17,7 @@ | |||
| "dnadesign/silverstripe-elemental": "<4.6" | |||
| }, | |||
| "require-dev": { | |||
| "sminnee/phpunit": "^5.7", | |||
| "sminnee/phpunit-mock-objects": "^3.4.5", | |||
| "phpunit/phpunit": "^9", | |||
There was a problem hiding this comment.
Suggested change
| "phpunit/phpunit": "^9", | |
| "phpunit/phpunit": "^9.5", |
| @@ -268,7 +269,11 @@ public function testExtractKeys() | |||
| $result = StaticSchema::inst()->extractKeys(['Foo', 'NotExists'], $arr); | |||
| $this->assertEquals(['test1', null], $result); | |||
|
|
|||
| $this->expectException(\PHPUnit_Framework_Error::class); | |||
| if (PHP_VERSION_ID < 80000) { | |||
| $this->expectNotice(); | |||
There was a problem hiding this comment.
Suggested change
| $this->expectNotice(); | |
| $this->expectNotice('StaticSchema throws notice when extracting on non-existent key on PHP 7'); |
| if (PHP_VERSION_ID < 80000) { | ||
| $this->expectNotice(); | ||
| } else { | ||
| $this->expectWarning(); |
There was a problem hiding this comment.
Suggested change
| $this->expectWarning(); | |
| $this->expectWarning('StaticSchema throws warning when extracting on non-existent key on PHP 8'); |
maxime-rainville
requested changes
Nov 1, 2021
emteknetnz
force-pushed
the
pulls/3/sapphire-test-nine
branch
from
cd1912a to
55b598d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10019