Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Disable schema introspection in non-dev #400

Conversation

unclecheese
Copy link

Disables schema introspection outside of dev. Tests to follow.

@unclecheese unclecheese changed the title NEW: Disable schema introspection in dev NEW: Disable schema introspection in non-dev Dec 20, 2021
@madmatt
Copy link
Member

madmatt commented Dec 21, 2021

Thanks @unclecheese, from my very uneducated eye this looks good to me! :)

README.md Outdated Show resolved Hide resolved
Co-authored-by: Michal Kleiner <[email protected]>
@madmatt
Copy link
Member

madmatt commented Mar 3, 2022

I merged your suggested change @michalkleiner, this keeps it consistent with the rest. I'm keen to get this merged in, however I just noticed there's a conflict in the README.md file now and realise that there's already a way to remove introspection, it's just done in code and for all environments (though you can use code to amend that).

See https://github.com/silverstripe/silverstripe-graphql#schema-introspection.

Does that invalidate the need for this PR perhaps?

[edited] Actually, on second thought I think that existing feature is designed to stop the dynamic endpoint that shows the introspection dynamically. The point is to make it static as a file in assets/ instead, so this is still required.

@madmatt
Copy link
Member

madmatt commented Mar 10, 2022

@unclecheese Do you mind if I get this conflict fixed and remove the draft status of this PR, building on top of your work? I've got a few different clients interested in seeing something like this merged in.

Thanks!

@unclecheese
Copy link
Author

Yeah, go for it!

@GuySartorelli
Copy link
Member

@madmatt are you still keen to fix the conflict on this PR?

@GuySartorelli
Copy link
Member

Given that this is still in draft, has conflicts, and is for v3 which we are no longer actively developing, I'm going to close this.
If someone is really passionate about getting this merged in, feel free to open a new PR with no merge conflicts.

@unclecheese unclecheese deleted the pulls/3/disable-schema-introspection branch July 18, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants