Pulls/master/ extendsive refactor #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
unclecheese
force-pushed
the
pulls/master/_extendsive-refactor
branch
from
196a39e to
a6a27c2
Compare
added 3 commits
June 23, 2021 12:54
…collector, add hiddenAncestor
unclecheese
pushed a commit
that referenced
this pull request
Jun 30, 2021
* First cut * Apply to queries, fix inheritance bugs * Tests passing * Initial fixes for decoupled * Numerous updates to union/interface generation to support Gatsby * Getting there * Back to schema generation in gatsby * Broke up Inheritance into separate services * Unit tests for new inheritance * Tests passing * Rename to SchemaConfigProvider * Linting * Add inheritance check for field mapping * Use correct event name, no dot syntax * Use unions on single results, e.g. has_one * NEW: Refactor to use interface queries (non-breaking) * Get tests passing * Allow type eager loading for types that don't appear in queries * Simplify exists() check so it doesn't create a new schema every time * Ensure method exists * MINOR: firstResult typed to SS_List for non-dataobject cases * Remove API change to SchemaUpdater * Linting * Fix method return type * Fix Enum overwriting local variable and breaking enumerated arrays * Add base resolver, allow native field to resolve * Change inheritance to apply on models, instead of updateSchema * Fix tests * Linting * Ensure inheritance follows versioned, include bespoke types in query collector, add hiddenAncestor * Cache query collection for performance Co-authored-by: Aaron Carlino <[email protected]>
unclecheese
pushed a commit
that referenced
this pull request
Jun 30, 2021
* First cut * Apply to queries, fix inheritance bugs * Tests passing * Initial fixes for decoupled * Numerous updates to union/interface generation to support Gatsby * Getting there * Back to schema generation in gatsby * Broke up Inheritance into separate services * Unit tests for new inheritance * Tests passing * Rename to SchemaConfigProvider * Linting * Add inheritance check for field mapping * Use correct event name, no dot syntax * Use unions on single results, e.g. has_one * NEW: Refactor to use interface queries (non-breaking) * Get tests passing * Allow type eager loading for types that don't appear in queries * Simplify exists() check so it doesn't create a new schema every time * Ensure method exists * MINOR: firstResult typed to SS_List for non-dataobject cases * Remove API change to SchemaUpdater * Linting * Fix method return type * Fix Enum overwriting local variable and breaking enumerated arrays * Add base resolver, allow native field to resolve * Change inheritance to apply on models, instead of updateSchema * Fix tests * Linting * Ensure inheritance follows versioned, include bespoke types in query collector, add hiddenAncestor * Cache query collection for performance Co-authored-by: Aaron Carlino <[email protected]>
| @@ -36,6 +36,7 @@ public function getIdentifier(): string | |||
| */ | |||
| public function apply(ModelType $type, Schema $schema, array $config = []): void | |||
| { | |||
| return; | |||
There was a problem hiding this comment.
Was that a mistake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #374