API Standardise OperationResolver::resolve() #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
|
@tractorcow, thanks for your PR! By analyzing the blame information on this pull request, I identified @chillu and @wilr to be potential reviewers |
Current coverage is 83.86% (diff: 97.95%)@@ master #28 diff @@
==========================================
Files 13 13
Lines 443 440 -3
Methods 74 73 -1
Messages 0 0
Branches 0 0
==========================================
- Hits 370 369 -1
+ Misses 73 71 -2
Partials 0 0
|
chillu
reviewed
Dec 20, 2016
| @@ -7,7 +7,7 @@ | |||
| * | |||
| * @todo Validation support | |||
| */ | |||
| class MutationCreator extends FieldCreator | |||
| abstract class MutationCreator extends FieldCreator | |||
There was a problem hiding this comment.
I was buggedby that as well, but assumed you couldn't declare a subclass of a concrete class as abstract - turns out you can!
chillu
approved these changes
Dec 20, 2016
unclecheese
pushed a commit
that referenced
this pull request
Dec 20, 2016
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Dec 23, 2016
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Jan 11, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Jan 14, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
chillu
pushed a commit
that referenced
this pull request
Jan 15, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
tractorcow
pushed a commit
to open-sausages/silverstripe-graphql
that referenced
this pull request
Jan 16, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Jan 18, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Jan 20, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Jan 20, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
that referenced
this pull request
Jan 31, 2017
API PaginatedQueryCreator is abstract PSR2 cleanup PHPDoc cleanup
unclecheese
pushed a commit
to unclecheese/silverstripe-graphql
that referenced
this pull request
Jan 27, 2021
…hange_icon WIP Pulls/4.0/402 button alignment in actions toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API PaginatedQueryCreator is abstract
PSR2 cleanup
PHPDoc cleanup