Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sort field mapping #24

Merged
merged 1 commit into from
Dec 19, 2016

Conversation

chillu
Copy link
Member

@chillu chillu commented Dec 18, 2016

Mainly designed to bridge case sensitivity between GraphQL (defaults to lower camel) and the SS ORM (defaults to upper camel). Will also come in handy for custom in-memory sorts, e.g. File.size

/cc @wilr

@helpfulrobot
Copy link

@chillu, thanks for your PR! By analyzing the blame information on this pull request, I identified @wilr to be a potential reviewer

@wilr
Copy link
Member

wilr commented Dec 18, 2016

@chillu Travis auth error? Tried restarting the job to no luck.

Mainly designed to bridge case sensitivity between GraphQL (defaults to lower camel) and the SS ORM (defaults to upper camel).
Will also come in handy for custom in-memory sorts, e.g. File.size
@codecov-io
Copy link

codecov-io commented Dec 19, 2016

Current coverage is 85.65% (diff: 100%)

Merging #24 into master will increase coverage by 0.09%

@@             master        #24   diff @@
==========================================
  Files            15         15          
  Lines           457        460     +3   
  Methods          76         76          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            391        394     +3   
  Misses           66         66          
  Partials          0          0          

Powered by Codecov. Last update 016ecb8...e02b0c9

@chillu
Copy link
Member Author

chillu commented Dec 19, 2016

@wilr Passing now

@wilr wilr merged commit 1894298 into silverstripe:master Dec 19, 2016
@chillu chillu deleted the pulls/custom-sort-mapping branch December 19, 2016 02:28
tractorcow pushed a commit to open-sausages/silverstripe-graphql that referenced this pull request Jan 16, 2017
unclecheese pushed a commit to unclecheese/silverstripe-graphql that referenced this pull request Jan 27, 2021
…eadcrumb_position

Make breadcrumbs and toolbar title position consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants